Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): throw an error if vite config is not found at provided path #16600

Conversation

dmitry-stepanenko
Copy link
Contributor

Current Behavior

If the path to vite.config cannot be resolved, @nrwl/vite:build executor will silently replace it with the one it is able to resolve

Expected Behavior

Should throw an error instead.

This change applies only to normalizeViteConfigFilePath function, I think that it is fine to replace vite config in normalizeViteConfigFilePathWithTree as it mutates the code instead of running it.

@vercel
Copy link

vercel bot commented Apr 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 27, 2023 5:56am

@dmitry-stepanenko dmitry-stepanenko changed the title feat(vite): throw error if vite config is not found at provided path feat(vite): throw an error if vite config is not found at provided path Apr 27, 2023
@github-actions
Copy link

github-actions bot commented May 4, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants