fix(nx-plugin): make cli schema json migration safer #16558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
AgentEnder
force-pushed
the
fix/nx-plugin/migration/cli-schema-json
branch
from
e9c4504 to
d8f1ada
Compare
FrozenPandaz
approved these changes
Apr 25, 2023
| output.warn({ | ||
| title: `Migrations file specified for ${packageJson.name} does not exist: ${migrationsPath}`, | ||
| bodyLines: [ | ||
| 'Please ensure that migrations that use the angular devkit are placed inside the `schematics` property, and migrations that use the nx devkit are placed inside the `generators` property.', |
There was a problem hiding this comment.
Suggested change
| 'Please ensure that migrations that use the angular devkit are placed inside the `schematics` property, and migrations that use the nx devkit are placed inside the `generators` property.', | |
| 'Please ensure that migrations that use the Angular Devkit are placed inside the `schematics` property, and migrations that use the Nx Devkit are placed inside the `generators` property.', |
AgentEnder
force-pushed
the
fix/nx-plugin/migration/cli-schema-json
branch
from
d8f1ada to
a6f827d
Compare
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…disk
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #