fix(core): do not replace legacy package mentions in binary files #16547
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FrozenPandaz
force-pushed
the
ignore-extensions
branch
from
3702f1c to
8d8bca8
Compare
FrozenPandaz
force-pushed
the
ignore-extensions
branch
from
8d8bca8 to
b815fb3
Compare
AgentEnder
approved these changes
Apr 25, 2023
FrozenPandaz
changed the title
jaysoo
reviewed
Apr 25, 2023
| '.jpx', | ||
| '.heic', | ||
| '.cur', | ||
| '.tgz', |
There was a problem hiding this comment.
.avif and .dcm extensions is missing for images
There was a problem hiding this comment.
pxz and pxd are also missing
| ]); | ||
|
|
||
| export function isBinaryFile(path: string) { | ||
| return binaryExtensions.has(extname(path)); |
There was a problem hiding this comment.
Do we want to list out more extensions like .pdf, .gz, .zip, etc.?
There's a long list here: https://github.com/sindresorhus/binary-extensions/blob/main/binary-extensions.json
There was a problem hiding this comment.
I added these to the list.. let's see if we want to import this list differently in the future. 🤔
FrozenPandaz
force-pushed
the
ignore-extensions
branch
from
b815fb3 to
c6f8f9d
Compare
FrozenPandaz
force-pushed
the
ignore-extensions
branch
from
c6f8f9d to
9338940
Compare
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Mentions of old packages are replaced in binary files such as images and
.jarfiles.Expected Behavior
Mentions of old packages are not replaced in binary files such as images and
.jarfiles.Related Issue(s)
Fixes #