Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): remote static serve target should not watch for changes #16542

Merged

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 25, 2023

Current Behavior

After switching to use the @nx/web:file-server executor, we didn't take into account that watch is set to true by default

Expected Behavior

Generate remote applications to set watch to false for static serve

We can't write a migration for this because we have no discernable way of knowing if an application is a remote, and other generators now generate a static-serve target that use the same exectuor.

Related Issue(s)

Fixes #16118

@Coly010 Coly010 requested a review from leosvelperez as a code owner April 25, 2023 15:12
@Coly010 Coly010 self-assigned this Apr 25, 2023
@vercel
Copy link

vercel bot commented Apr 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 25, 2023 3:12pm

@Coly010 Coly010 enabled auto-merge (squash) April 25, 2023 15:23
@Coly010 Coly010 merged commit 4e0df09 into nrwl:master Apr 25, 2023
@Coly010 Coly010 deleted the angular/watch-false-for-mf-serve-static branch April 25, 2023 15:46
@github-actions
Copy link

github-actions bot commented May 1, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

in MFE Change in code trigger the build for all the apps(static-served and devRemotes)
2 participants