fix(testing): fix react CT w/ vite and dependant projects #16475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
added
scope: react
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
1263e71 to
7086588
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
7086588 to
6bbd5cb
Compare
jaysoo
reviewed
Apr 25, 2023
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
6bbd5cb to
679a190
Compare
mandarini
approved these changes
Apr 26, 2023
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
679a190 to
d57980d
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
d57980d to
7bbc20d
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
7bbc20d to
75b4dd6
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
75b4dd6 to
d5d9819
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
97bba84 to
4b869c7
Compare
xiongemi
approved these changes
Apr 28, 2023
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
4b869c7 to
37bd4e5
Compare
barbados-clemens
force-pushed
the
fix/vite-react-ct
branch
from
37bd4e5 to
a63c6ab
Compare
FrozenPandaz
approved these changes
Apr 28, 2023
jaysoo
approved these changes
Apr 28, 2023
FrozenPandaz
pushed a commit
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit ebcc436)
This was referenced Apr 29, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
When using vite with react component testing and trying to import a dependent project, vite will throw an error saying it's outside of the allows list of reading from the file system
Expected Behavior
vite should be allowed to react dependent projects files in CT
Related Issue(s)
Note this is only an issue in CT because cypress loads the given vite file which is missing the fs allow entry, but isn't a problem when serving projects via nx due to vite executor providing this value automatically (which cypress does not do)
TODO: