fix(nextjs): remove the need to install @nx/next for production builds #16469
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
| @@ -6,4 +6,4 @@ export { componentGenerator } from './src/generators/component/component'; | |||
| export { libraryGenerator } from './src/generators/library/library'; | |||
| export { pageGenerator } from './src/generators/page/page'; | |||
| export { withNx } from './plugins/with-nx'; | |||
| export { composePlugins } from './src/utils/config'; | |||
There was a problem hiding this comment.
Moved composePlugins to its own file so we can copy the compiled version to dist during build.
| : joinPathFragments(outputDir, '.next'); | ||
| } else { | ||
| return '.next'; | ||
| try { |
There was a problem hiding this comment.
This logic will only be needed when running through Nx. i.e. nx serve <app> --prod
jaysoo
force-pushed
the
fix/next-remove-dependency-to-with-nx
branch
from
24af604 to
d6f3ffa
Compare
packages/next/plugins/with-nx.ts
Outdated
| } | ||
|
|
||
| return '.next'; |
There was a problem hiding this comment.
For deployment platforms like Vercel, or a self-contained Docker image, the folder should just be .next (or whatever the user sets it to).
| } | ||
|
|
||
| return nextConfig.distDir || '.next'; |
There was a problem hiding this comment.
For Vercel and other platforms (including self-contained Docker images), use .next or whatever the user sets in their next.config.js.
| }; | ||
| } else { | ||
| const { |
There was a problem hiding this comment.
Inline all of the require to run only during build phase. We don't need these to production.
jaysoo
force-pushed
the
fix/next-remove-dependency-to-with-nx
branch
2 times, most recently
from
ff2eea9 to
23ba8bd
Compare
| ); | ||
| writeFileSync(join(helpersPath, 'with-nx.js'), getWithNxContent()); | ||
| writeFileSync( | ||
| join(helpersPath, 'compiled.js'), |
There was a problem hiding this comment.
A smaller version of with-nx.js that does not depend on Nx packages.
jaysoo
force-pushed
the
fix/next-remove-dependency-to-with-nx
branch
3 times, most recently
from
19cb3bd to
3a6f537
Compare
jaysoo
force-pushed
the
fix/next-remove-dependency-to-with-nx
branch
from
3a6f537 to
56b384f
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
This PR brings back the compiled version of the
withNxfunction. This allows@nx/nextto not be installed as a production dependency, which avoids pulling in@nx/devkitand other dev packages.Current Behavior
@nx/nextor@nrwl/nextmust be installed as production dependency.Expected Behavior
@nx/nextor@nrwl/nextdon't need to be installed for the compiled app to run.Related Issue(s)
Fixes #15931