Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): correct importPath and import updates for migration to local plugins #16437

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Apr 20, 2023

Current Behavior

  • If the workspace-generator used any utils that lived in the tools folder, their import paths would be broken
  • If the workspace has an npmScope, the import path for the plugin is ${npmScope}/workspace-plugin
  • The workspace-generator wrapper was clobbering any arguments called "name" since there was a positional called name as well.
    • This was something that was worked around in the previous yargs config that I did not notice

Expected Behavior

  • If the workspace-generator used any utils that lived in the tools folder, their import paths are not broken
  • If the workspace has an npmScope, the import path for the plugin is @${npmScope}/workspace-plugin
  • You can pass --name to converted generators

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 20, 2023 5:35pm

@AgentEnder AgentEnder force-pushed the fix/address-some-issues-in-workspace-plugin-migration branch from 2a52122 to 29dc8cb Compare April 20, 2023 16:53
@AgentEnder AgentEnder force-pushed the fix/address-some-issues-in-workspace-plugin-migration branch from 29dc8cb to 5619255 Compare April 20, 2023 16:58
@AgentEnder AgentEnder force-pushed the fix/address-some-issues-in-workspace-plugin-migration branch from 5619255 to b7b6141 Compare April 20, 2023 17:32
@AgentEnder AgentEnder requested a review from FrozenPandaz April 20, 2023 17:45
@FrozenPandaz FrozenPandaz merged commit b44dbf9 into nrwl:master Apr 20, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants