Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(js): update the lib version in base tsconfig to es2020 #16429

Merged
merged 1 commit into from
Apr 20, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 20, 2023

Current Behavior

We generate our base tsconfig with compilerOptions.lib = es2017

Expected Behavior

We should generate our base tsconfig with a more modern value for compilerOptions.lib

Related Issue(s)

Fixes #16309

@Coly010 Coly010 self-assigned this Apr 20, 2023
@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 20, 2023 8:58am

@Coly010 Coly010 merged commit 9f4d02d into nrwl:master Apr 20, 2023
@Coly010 Coly010 deleted the js/update-lib-tsconfig branch April 20, 2023 17:10
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update tsconfig lib version in tsconfig.base.json.
3 participants