Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): add option to generate a package.json to build executor #16428

Merged
merged 1 commit into from
May 8, 2023

Conversation

jwalton9
Copy link
Contributor

Current Behavior

There's currently no way of generating a minimal package.json when using the vite:build executor

Expected Behavior

The ability to generate a package.json including only the dependencies of the project should be enabled by setting generatePackageJson: true in the vite:build executor options

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 8, 2023 2:12pm

Copy link
Member

@jaysoo jaysoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @jwalton9 thanks for the PR! I think it's a good idea. Let me know if you need more clarification and I can elaborate more.

Since Nx 16 is right around the corner, I think we'll leave this feature out until after the release. It is already a huge release as is.

packages/vite/src/executors/build/build.impl.ts Outdated Show resolved Hide resolved
e2e/vite/src/vite.test.ts Outdated Show resolved Hide resolved
@jwalton9 jwalton9 force-pushed the vite/generate-package-json branch from e90f3a4 to e9593c8 Compare May 4, 2023 12:54
@jwalton9 jwalton9 requested a review from jaysoo May 4, 2023 12:55
@jwalton9
Copy link
Contributor Author

jwalton9 commented May 4, 2023

@jaysoo Are we good to go ahead with this change now v16 is out?

@jensbodal
Copy link
Contributor

Fwiw I tried adding this a month ago here #16045 and then three weeks ago with a more generic solution here: #16330. Either way I just want this feature available but seems odd that my first one was just closed without feedback or offer of improving it.

@mandarini
Copy link
Member

Hello @jwalton9 ! I'm taking a look at this right now, and if all's well I'll approve and merge, thank you for your contribution!

@jensbodal thank you for your comment! We are trying our best to meet our users needs! However, we did reply to your PR with feedback! :) #16045 (comment) In any case, I am sorry if you felt that your PR was dismissed without a reason, we are trying our best! :)

mandarini

This comment was marked as duplicate.

Copy link
Member

@mandarini mandarini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR!

@mandarini mandarini force-pushed the vite/generate-package-json branch from e9593c8 to 365a9b4 Compare May 8, 2023 14:08
@mandarini mandarini enabled auto-merge (squash) May 8, 2023 14:09
@mandarini mandarini self-assigned this May 8, 2023
@mandarini mandarini merged commit 402a00f into nrwl:master May 8, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants