-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(vite): add option to generate a package.json to build executor #16428
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @jwalton9 thanks for the PR! I think it's a good idea. Let me know if you need more clarification and I can elaborate more.
Since Nx 16 is right around the corner, I think we'll leave this feature out until after the release. It is already a huge release as is.
e90f3a4
to
e9593c8
Compare
@jaysoo Are we good to go ahead with this change now v16 is out? |
Hello @jwalton9 ! I'm taking a look at this right now, and if all's well I'll approve and merge, thank you for your contribution! @jensbodal thank you for your comment! We are trying our best to meet our users needs! However, we did reply to your PR with feedback! :) #16045 (comment) In any case, I am sorry if you felt that your PR was dismissed without a reason, we are trying our best! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your PR!
e9593c8
to
365a9b4
Compare
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
There's currently no way of generating a minimal
package.json
when using thevite:build
executorExpected Behavior
The ability to generate a
package.json
including only the dependencies of the project should be enabled by settinggeneratePackageJson: true
in thevite:build
executor optionsRelated Issue(s)
Fixes #