Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): schematics warning should only occur when run as schematic #16396

Merged
merged 1 commit into from
Apr 19, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Apr 19, 2023

Current Behavior

Some generators have their schematic compat versions in the same file as the generator.
Therefore, when running a generator as a generator, when the file is required, the warning for schematic usage will still be printed.

Expected Behavior

Only print the schematic warning when used as a schematic

Related Issue(s)

Fixes #

@Coly010 Coly010 requested a review from leosvelperez as a code owner April 19, 2023 09:08
@Coly010 Coly010 self-assigned this Apr 19, 2023
@vercel
Copy link

vercel bot commented Apr 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 19, 2023 9:09am

@Coly010 Coly010 merged commit 4446bf7 into nrwl:master Apr 19, 2023
@Coly010 Coly010 deleted the angular/fix-schematic-warning branch April 19, 2023 10:23
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants