Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nextjs): remove "--server=..." app generator option #16312

Merged

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Apr 14, 2023

Removes the server option for Next.js app generator, which was deprecated back in Nx 13.

Notes

  • Users can use the @nrwl/next:custom-server generator or pass the --customServer flag to the app generator to generate the new setup.
  • Removes the customServerPath executor option since it is no longer needed, and has been deprecated since Nx 13.
  • Also removes the standaloneConfig from app/lib generator since it does nothing.

@vercel
Copy link

vercel bot commented Apr 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 14, 2023 5:12pm

@jaysoo jaysoo force-pushed the feat/remove-deprecated-custom-server-path branch from 0e90ba7 to fb08453 Compare April 14, 2023 16:11
@jaysoo jaysoo changed the title feat(nextjs): remove customServerPath app generator option feat(nextjs): remove "--server=..." app generator option Apr 14, 2023
@jaysoo jaysoo force-pushed the feat/remove-deprecated-custom-server-path branch from fb08453 to 83a3858 Compare April 14, 2023 16:16
@jaysoo jaysoo force-pushed the feat/remove-deprecated-custom-server-path branch from 83a3858 to 4ed5cfc Compare April 14, 2023 17:00
@jaysoo jaysoo merged commit c3c77d5 into nrwl:master Apr 14, 2023
@jaysoo jaysoo deleted the feat/remove-deprecated-custom-server-path branch April 14, 2023 17:57
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants