feat(repo): migrate to pnpm #16284
Merged
feat(repo): migrate to pnpm #16284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
meeroslav
force-pushed
the
yarn-to-pnpm
branch
2 times, most recently
from
18620e2 to
8d9bd94
Compare
meeroslav
changed the title
meeroslav
requested review from
StalkAltan,
vsavkin,
FrozenPandaz,
JamesHenry,
jaysoo,
AgentEnder,
nartc,
ndcunningham,
Coly010 and
leosvelperez
as code owners
meeroslav
force-pushed
the
yarn-to-pnpm
branch
2 times, most recently
from
63644bb to
b912020
Compare
meeroslav
force-pushed
the
yarn-to-pnpm
branch
3 times, most recently
from
200ee2f to
cbd3ff2
Compare
meeroslav
commented
Apr 25, 2023
| @@ -109,7 +113,8 @@ describe('react native', () => { | |||
| }); | |||
|
|
|||
| if (isOSX()) { | |||
| it('should pod install', async () => { | |||
| // TODO(@meeroslav): this test is causing git-hasher to overflow with arguments. Enable when it's fixed. | |||
| xit('should pod install', async () => { | |||
There was a problem hiding this comment.
According to @xiongemi this is the test that is failing the remaining 4 tests
meeroslav
commented
Apr 25, 2023
packages/react-native/package.json
Outdated
| @@ -42,7 +42,7 @@ | |||
| "@nx/workspace": "file:../workspace" | |||
| }, | |||
| "peerDependencies": { | |||
| "react-native": "^0.71.7" | |||
| "react-native": ">= 0.71.0" | |||
There was a problem hiding this comment.
Fix from #16524 for expo e2e
FrozenPandaz
approved these changes
Apr 25, 2023
This was referenced Apr 28, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates our repo from
yarn classictopnpm:Current status:
e2e-jsswctest is failing and severale2e-react-nativetests are failingCurrent Behavior
Expected Behavior
Related Issue(s)
Fixes #