Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(misc): consolidate common functionality and messaging across nx init flows #16283

Merged
merged 1 commit into from
Apr 14, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Apr 13, 2023

Current Behavior

The different nx init flows have messaging and implementation differences for common functionalities.

Expected Behavior

The different nx init flows have common messaging and functionalities where it makes sense.

Changes made:

  • Standardized common messaging for similar messages across flows
  • CRA now prompts for Nx Cloud usage, don't default to true
  • CRA can skip prompts with an interactive flag

Note: A follow-up PR (#16287) will standardize and expose all the different flags so they are shown in the docs and the terminal help. As part of that:

  • The flag for Nx Cloud will be standardized for all flows
  • The currently internal --yes flag in some flows will be standardized as --interactive for all flows
  • Flags for specific flows will have a disclaimer in their description to communicate the flows that use them

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Apr 13, 2023
@vercel
Copy link

vercel bot commented Apr 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 13, 2023 1:57pm

@leosvelperez leosvelperez force-pushed the misc/consolidate-nx-init-flows branch from 60c8733 to 5b2528f Compare April 13, 2023 13:48
@leosvelperez leosvelperez changed the title cleanup(misc): consolidate messaging across nx init flows cleanup(misc): consolidate common functionality and messaging across nx init flows Apr 13, 2023
@leosvelperez leosvelperez marked this pull request as ready for review April 13, 2023 14:41
@AgentEnder AgentEnder merged commit 9a94281 into nrwl:master Apr 14, 2023
@leosvelperez leosvelperez deleted the misc/consolidate-nx-init-flows branch April 14, 2023 14:50
peppoasap pushed a commit to peppoasap/nx that referenced this pull request Apr 18, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants