-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cleanup(misc): consolidate common functionality and messaging across nx init flows #16283
Merged
AgentEnder
merged 1 commit into
nrwl:master
from
leosvelperez:misc/consolidate-nx-init-flows
Apr 14, 2023
Merged
cleanup(misc): consolidate common functionality and messaging across nx init flows #16283
AgentEnder
merged 1 commit into
nrwl:master
from
leosvelperez:misc/consolidate-nx-init-flows
Apr 14, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
force-pushed
the
misc/consolidate-nx-init-flows
branch
from
April 13, 2023 10:29
9ee7376
to
60c8733
Compare
leosvelperez
force-pushed
the
misc/consolidate-nx-init-flows
branch
from
April 13, 2023 13:48
60c8733
to
5b2528f
Compare
leosvelperez
changed the title
cleanup(misc): consolidate messaging across nx init flows
cleanup(misc): consolidate common functionality and messaging across nx init flows
Apr 13, 2023
leosvelperez
requested review from
FrozenPandaz,
AgentEnder,
vsavkin,
jaysoo,
xiongemi,
mandarini and
Coly010
as code owners
April 13, 2023 14:41
jaysoo
approved these changes
Apr 13, 2023
Coly010
approved these changes
Apr 14, 2023
AgentEnder
approved these changes
Apr 14, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
The different
nx init
flows have messaging and implementation differences for common functionalities.Expected Behavior
The different
nx init
flows have common messaging and functionalities where it makes sense.Changes made:
true
interactive
flagNote: A follow-up PR (#16287) will standardize and expose all the different flags so they are shown in the docs and the terminal help. As part of that:
--yes
flag in some flows will be standardized as--interactive
for all flowsRelated Issue(s)
Fixes #