feat(nx-plugin): remove cli property from generators and executors schema.json file #16259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
changed the title
vsavkin
reviewed
Apr 12, 2023
| // If it doesn't exist, we will check if the implementation references @angular/devkit. | ||
| const shouldBeNx = !!collection.generators[name]; | ||
| const shouldBeNg = !!collection.schematics[name]; | ||
| let cli = entry.cli; |
There was a problem hiding this comment.
I'd call the var "useAngularDevkitToRunMigration"
vsavkin
reviewed
Apr 12, 2023
| 'from "@angular-devkit', | ||
| ].some((s) => implStringContents.includes(s)) | ||
| ) { | ||
| cli ??= 'angular'; |
AgentEnder
force-pushed
the
feat/dont-generate-cli-prop-in-schema-json
branch
from
c3970b6 to
4a07183
Compare
AgentEnder
force-pushed
the
feat/dont-generate-cli-prop-in-schema-json
branch
from
4a07183 to
014d570
Compare
AgentEnder
force-pushed
the
feat/dont-generate-cli-prop-in-schema-json
branch
from
014d570 to
ef45f67
Compare
…d update migrations.json
AgentEnder
force-pushed
the
feat/dont-generate-cli-prop-in-schema-json
branch
from
ef45f67 to
5a45d9e
Compare
FrozenPandaz
approved these changes
Apr 13, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
We don't read these props but still generate them
Expected Behavior
We don't generate them
Related Issue(s)
Fixes #