docs(core): env variable pages link to each other #16258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isaacplmann
requested review from
bcabanes,
juristr,
StalkAltan and
rarmatei
as code owners
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 69b587c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
StalkAltan
approved these changes
Apr 12, 2023
juristr
approved these changes
Apr 13, 2023
| @@ -1,6 +1,6 @@ | |||
| # Environment Variables | |||
|
|
|||
| ## NX_BRANCH and NX_CI_EXECUTION_ID | |||
| ### NX_BRANCH and NX_CI_EXECUTION_ID | |||
There was a problem hiding this comment.
Could we have the same table layout her as for the Nx env variables?
| @@ -32,3 +32,5 @@ Nx will set the following environment variables so they can be accessible within | |||
| | NX_TASK_TARGET_CONFIGURATION | string | Set to the configuration name of the task being run. Use this to tell which configuration of the target is being run. | | |||
| | NX_DRY_RUN | boolean | Set to `true` during dry runs of generators. Use this to avoid side effects during generators. | | |||
| | NX_INTERACTIVE | boolean | Set to `false` when running generators with `--interactive=false`. Use this to prevent prompting during generators | | |||
|
|
|||
| When using distributed caching, [Nx Cloud Environment Variables](/nx-cloud/reference/env-vars) are also available. | |||
There was a problem hiding this comment.
LGTM, potentially we could have it as a callout here as well. Like "Looking for Nx Cloud environment variables? ..."
peppoasap
pushed a commit
to peppoasap/nx
that referenced
this pull request
Apr 18, 2023
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Links the environment variable pages to each other