Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): remove deprecated workspace-lint #16212

Merged
merged 1 commit into from
Oct 13, 2023

Conversation

AgentEnder
Copy link
Member

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Apr 10, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 12, 2023 9:23pm

@AgentEnder AgentEnder added the target: next major version To be merged for the next major version release label Apr 11, 2023
@puku0x
Copy link
Contributor

puku0x commented Apr 13, 2023

Will Nx provide a way to align the package versions like workspace-lint in the future release?

@AgentEnder AgentEnder removed the target: next major version To be merged for the next major version release label Oct 7, 2023
@AgentEnder AgentEnder marked this pull request as ready for review October 7, 2023 01:33
@AgentEnder AgentEnder requested review from FrozenPandaz, jaysoo, a team and vsavkin as code owners October 7, 2023 01:33
Copy link
Collaborator

@JamesHenry JamesHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This can’t be a chore right, it’s a significant user facing change? chore would cause it to not appear in the changelog

@AgentEnder AgentEnder changed the title chore(core): remove deprecated workspace-lint feat(core): remove deprecated workspace-lint Oct 10, 2023
@AgentEnder AgentEnder requested a review from JamesHenry October 10, 2023 16:39
@AgentEnder AgentEnder force-pushed the chore/remove-workspace-lint branch from 020355d to f1cc392 Compare October 10, 2023 16:51
packages/nx/project.json Outdated Show resolved Hide resolved
@FrozenPandaz FrozenPandaz merged commit 09ff419 into nrwl:master Oct 13, 2023
2 checks passed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 20, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants