Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): run-many doesn't strip quotes surrounding target names #16211

Merged
merged 1 commit into from
Apr 13, 2023
Merged

fix(core): run-many doesn't strip quotes surrounding target names #16211

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion packages/nx/src/command-line/nx-commands.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1093,7 +1093,10 @@ function parseCSV(args: string[] | string) {
if (Array.isArray(args)) {
return args;
}
return args.split(',');
const items = args.split(',');
return items.map((i) =>
i.startsWith('"') && i.endsWith('"') ? i.slice(1, -1) : i
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we handle single quotes?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nope - double checked and we only handle double quotes for nx run as well - one could probably argue that this should change, but I digress. Lets fix this first, can attack single quotes more holistically later.

);
}

function linkToNxDevAndExamples(yargs: yargs.Argv, command: string) {
Expand Down