Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(core): allow dependsOn to accept a single project dependency #16100

Merged

Conversation

AgentEnder
Copy link
Member

@AgentEnder AgentEnder commented Apr 4, 2023

Current Behavior

In its object form, dependsOn has a projects property. This property takes a string, despite being plural, and only accepts self or dependencies as its value.

Expected Behavior

projects can be an array of project names, but supports {self} and {dependencies} as tokens

Related Issue(s)

Fixes #16100

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 10, 2023 4:30pm

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have separate tabs for the old and new syntax

@AgentEnder AgentEnder force-pushed the feat/allow-specific-projects-in-depends-on branch from 212977b to 6cc8098 Compare April 10, 2023 16:23
Copy link
Collaborator

@isaacplmann isaacplmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the feature is great, but I would restructure the docs a bit. If you want, you can merge and then I can update the docs section.

I think we should do it like this:

  • Full dependsOn syntax structure with tabs for < 16 and 16+
  • Examples of usage with tabs for < 16 and 16+
  • Specifying individual projects should still be in a tab for 16+ even though there is no corresponding < 16 tab

@AgentEnder
Copy link
Member Author

AgentEnder commented Apr 10, 2023

If you want, you can merge and then I can update the docs section.

Sure, that sounds good. Thanks Issac!

@AgentEnder AgentEnder enabled auto-merge (squash) April 10, 2023 16:42
@AgentEnder AgentEnder merged commit f2f6e35 into nrwl:master Apr 10, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants