Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(nx-dev): add markdoc title card component #16098

Merged

Conversation

bcabanes
Copy link
Member

@bcabanes bcabanes commented Apr 4, 2023

No description provided.

@vercel
Copy link

vercel bot commented Apr 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 5, 2023 0:27am

@bcabanes bcabanes self-assigned this Apr 4, 2023
@bcabanes bcabanes enabled auto-merge (squash) April 4, 2023 20:40
Copy link
Member

@juristr juristr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should make it s.t. the cards expand on the entire width.

Right now they look as follows:
image

I'd rather prefer something like this

image

nx-dev/ui-markdoc/src/lib/tags/cards.component.tsx Outdated Show resolved Hide resolved
@bcabanes
Copy link
Member Author

bcabanes commented Apr 5, 2023

@juristr They take all the space by default, it respects the number of columns you put in {% cards cols="x" %}.

@bcabanes bcabanes merged commit ee1f7c1 into nrwl:master Apr 5, 2023
@bcabanes bcabanes deleted the feat/nx-dev/add-title-card-component branch April 5, 2023 13:18
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants