Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): should not throw 'unable to resolve nx/package.json' #16072

Merged
merged 1 commit into from
Apr 3, 2023
Merged

fix(core): should not throw 'unable to resolve nx/package.json' #16072

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions packages/nx/bin/nx.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ import {
getNxRequirePaths,
} from '../src/utils/installation-directory';
import { major } from 'semver';
import { readJsonFile } from '../src/utils/fileutils';
import { stripIndents } from '../src/utils/strip-indents';
import { readModulePackageJson } from '../src/utils/package-json';
import { execSync } from 'child_process';

function main() {
Expand Down Expand Up @@ -163,12 +163,17 @@ function warnIfUsingOutdatedGlobalInstall(
}
}

function getLocalNxVersion(workspace: WorkspaceTypeAndRoot): string {
return readJsonFile(
require.resolve('nx/package.json', {
paths: getNxRequirePaths(workspace.dir),
})
).version;
function getLocalNxVersion(workspace: WorkspaceTypeAndRoot): string | null {
const localNxPackages = ['nx', '@nrwl/tao', '@nrwl/cli'];
for (const pkg of localNxPackages) {
try {
const { packageJson } = readModulePackageJson(
'nx',
getNxRequirePaths(workspace.dir)
);
return packageJson.version;
} catch {}
}
}

function _getLatestVersionOfNx(): string {
Expand Down