Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(repo): add brew cache to preinstall step on nightly #16048

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

meeroslav
Copy link
Contributor

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@meeroslav meeroslav requested a review from vsavkin as a code owner April 3, 2023 08:03
@meeroslav meeroslav self-assigned this Apr 3, 2023
@vercel
Copy link

vercel bot commented Apr 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
nx-dev ⬜️ Ignored (Inspect) Apr 3, 2023 8:04am

@nx-cloud
Copy link

nx-cloud bot commented Apr 3, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5b1e91a. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@FrozenPandaz
Copy link
Collaborator

@xiongemi @jaysoo @meeroslav

TODO: it's odd that our key for the cache is based on the node version. Shouldn't it be based off of the brew hash or something homebrew related?

@FrozenPandaz FrozenPandaz merged commit db0fd2f into nrwl:master Apr 3, 2023
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
@meeroslav meeroslav deleted the add-brew-catch-to-preinstall branch April 27, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants