Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): fix path and selector handling in directive generator #16017

Merged
merged 1 commit into from
Apr 3, 2023

Conversation

leosvelperez
Copy link
Member

@leosvelperez leosvelperez commented Mar 31, 2023

Current Behavior

The directive generator:

  • doesn't handle that npmScope could be undefined
  • doesn't add the app or lib segment to the path based on the project type

Expected Behavior

The directive generator builds correctly the selector and path.

Note: Follow-up PRs will make this logic more consistent across component, directive and pipe generators.

Related Issue(s)

Fixes #

@leosvelperez leosvelperez self-assigned this Mar 31, 2023
@vercel
Copy link

vercel bot commented Mar 31, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 31, 2023 at 4:43PM (UTC)

@leosvelperez leosvelperez marked this pull request as ready for review March 31, 2023 17:12
@leosvelperez leosvelperez requested a review from Coly010 as a code owner March 31, 2023 17:12
Copy link
Contributor

@Coly010 Coly010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved! But added some comments for consideration

@leosvelperez leosvelperez merged commit 9b60863 into nrwl:master Apr 3, 2023
@leosvelperez leosvelperez deleted the angular/directive-fixes branch April 3, 2023 08:50
@github-actions
Copy link

github-actions bot commented Apr 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants