feat(core): allow referencing other packages to specify implementations for executors + generators #15987
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
requested changes
Mar 30, 2023
There was a problem hiding this comment.
I don't think this will work -- This makes the migration story for plugin's really hard. If a community plugin extends one of our plugin's executors collections its easy for updating Nx to break that plugin's targets since their options would not get migrated.
At minimum we need to only allow this for @nrwl -> @nx, and remove it after v17. Either way this is quite ugly imho, I'm not sure its the path we should go down 🤔
FrozenPandaz
force-pushed
the
extend-executors
branch
from
f2d4412 to
cf1724c
Compare
FrozenPandaz
force-pushed
the
extend-executors
branch
from
cf1724c to
e2bf8aa
Compare
FrozenPandaz
changed the title
AgentEnder
approved these changes
Mar 31, 2023
FrozenPandaz
force-pushed
the
extend-executors
branch
from
e2bf8aa to
ddf9f1c
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
Generators and executors cannot specify that their schema and implementation are in a different package.
Expected Behavior
Generators and executors can specify that their schema and implementation are in a different package.
Related Issue(s)
Fixes #