-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(misc): skip formatting files in nested generator calls #15961
Merged
FrozenPandaz
merged 1 commit into
nrwl:master
from
leosvelperez:misc/skip-nested-format-files
Mar 31, 2023
Merged
fix(misc): skip formatting files in nested generator calls #15961
FrozenPandaz
merged 1 commit into
nrwl:master
from
leosvelperez:misc/skip-nested-format-files
Mar 31, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
leosvelperez
requested review from
AgentEnder,
FrozenPandaz,
mandarini,
jaysoo,
Coly010,
meeroslav,
JamesHenry,
ndcunningham,
nartc and
xiongemi
as code owners
March 29, 2023 16:12
mandarini
approved these changes
Mar 29, 2023
AgentEnder
approved these changes
Mar 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nx-plugin changes look good
meeroslav
approved these changes
Mar 31, 2023
FrozenPandaz
approved these changes
Mar 31, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
skipFormat: true
to the nested generators which results in multipleformatFiles
invocations during a generator run.skipFormat
flag.The above have performance implications in the generator runs.
Expected Behavior
Generators invoking other generators explicitly pass the
skipFormat: true
to prevent multipleformatFiles
runs during a generator run.Related Issue(s)
Fixes #