Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(repo): remove command from the output to match test #15950

Merged
merged 2 commits into from
Mar 30, 2023

Conversation

meeroslav
Copy link
Contributor

@meeroslav meeroslav commented Mar 29, 2023

The test 'should handle file renames' outputs in verbose mode:

$ /tmp/nx-e2e--2332-bKA8ArUNOawE/nx/proj3710160/node_modules/.bin/nx print-affected --uncommitted --select projects
myapp4659802, myapp4659802-e2e, myapp9813790, myapp9813790-e2e

which fails the test that doesn't expect the command to be visible in the log.

This PR strips the command before checking the asserts

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Mar 29, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Mar 29, 2023 at 9:19AM (UTC)

@FrozenPandaz FrozenPandaz merged commit 482a77d into nrwl:master Mar 30, 2023
@github-actions
Copy link

github-actions bot commented Apr 5, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 5, 2023
@meeroslav meeroslav deleted the fix-nx-run-test branch April 27, 2023 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants