cleanup(angular): consolidate and improve e2e-angular-core tests

[leosvelperez]

What it does

• Remove some duplicated work:
  • Multiple tests covering the same task runs with no added value
  • Generation of new projects when the existing ones could be reused
• Remove an invalid test suite that's testing something we don't target to support ng-cli.test.ts
• Improve ports management/cleanup
• Add caching to creating Angular CLI workspaces

With the changes in the PR, the time is reduced, but it's still insufficient to meet the target. The last run did end up below the 15-minute mark (14m 27s), but there's currently a test case that's temporarily disabled which will bring the time up once enabled. In a separate branch/PR I'll explore splitting the test project.

The latest run took 12m 56s, so we seem to meet the target now. We'll keep an eye on it.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment

Name	Status	Preview	Comments	Updated
nx-dev	⬜️ Ignored (Inspect)			Mar 28, 2023 at 10:05AM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit fed7b0c. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=b4eef1770772dbb8bf12a2a1c60894a73f5da656 --head=fed7b0c1d31414582176630fdf042e108408071c --parallel=1
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=b4eef1770772dbb8bf12a2a1c60894a73f5da656 --head=fed7b0c1d31414582176630fdf042e108408071c --parallel=3
• nx affected --target=build --base=b4eef1770772dbb8bf12a2a1c60894a73f5da656 --head=fed7b0c1d31414582176630fdf042e108408071c --parallel=3
• nx affected --target=test --base=b4eef1770772dbb8bf12a2a1c60894a73f5da656 --head=fed7b0c1d31414582176630fdf042e108408071c --parallel=1
• nx-cloud record -- nx format:check --base=b4eef1770772dbb8bf12a2a1c60894a73f5da656 --head=fed7b0c1d31414582176630fdf042e108408071c
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[meeroslav]

@leosvelperez, when you look at the tests and their timings:

Total time: 1057306ms = ~17min

Test details
angular-linting.test.ts (70.254 s)
config.test.ts (71.819 s)
module-federation.test.ts (297.171 s)
ng-add.test.ts (345.513 s)
ng-cli.test.ts (33.616 s)
projects.test.ts (235.823 s)

You can spot several bottlenecks:

• Linting does not need to be a separate suite, and can reuse projects/apps/libs from e.g. projects.test.ts (at 'should generate an app, a lib, link them, build, serve and test both correctly'). This would likely save a minute of work
• Same goes for Angular Config that just runs on a default application (same like linter)
• On ng-add we keep running NgNew for each test which is a very expensive operation. We could apply the same caching logic as we have for newProject where we would generate it only once in the temp folder and then copy it over for each subsequent test.
• Module federation could be a separate e2e project

[leosvelperez]

@meeroslav thanks for the tips! Those are great and I will work on applying them.

As mentioned in the PR description, I'll split the tests on a separate PR. I also want to check the angular-extensions project and split them more evenly, so I'll keep that separate.

[meeroslav]

Please note that each test project splitting leads to a multiplication of git checkout, yarn install, verdaccio publish...

This should truly be only the last resort and only makes sense for test projects that take longer than 10 minutes since the preparation part often takes up to 3-4 minutes.

[leosvelperez]

Please note that each test project splitting leads to a multiplication of git checkout, yarn install, verdaccio publish...

This should truly be only the last resort and only makes sense for test projects that take longer than 10 minutes since the preparation part often takes up to 3-4 minutes.

That is why I'm keeping it as a separate change and don't want to just extract the MF tests into a project. If it comes to splitting the projects, it would be better to split the current two projects into three to have a more even split.

[leosvelperez]

@meeroslav I addressed the changes you requested except:

• Splitting Module Federation tests into a separate test project, as mentioned previously, splitting the current Angular e2e tests is something I might explore in a different PR, though the last run for this PR was 12m 56s, so we are on target, at least for now
• Merging the Angular Config test suite with another. We're keeping this one separate. Its setup is not that of a regular workspace because we use angular.json with v1 format. It's not impossible to merge it with another suite, but I rather not do it. It'd be messy with the setup and cleanup between tests and affect the readability of the test suite.

Additionally, I removed an additional test suite I realized was testing something we don't really target to support, so we shouldn't be testing it.

[meeroslav]

Great work! Thank you!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.