fix(core): add warning if running on an outdated global installation #15408
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
6a1e4f3 to
0b8ae09
Compare
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
0b8ae09 to
f7322c0
Compare
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
f7322c0 to
8ac2c24
Compare
AgentEnder
requested review from
vsavkin,
FrozenPandaz,
bcabanes,
isaacplmann and
juristr
as code owners
bcabanes
approved these changes
Mar 3, 2023
FrozenPandaz
requested changes
Mar 3, 2023
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
8ac2c24 to
22a52f6
Compare
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
22a52f6 to
e98b338
Compare
AgentEnder
force-pushed
the
fix/warn-if-outdated-global-install
branch
from
e98b338 to
cf35973
Compare
FrozenPandaz
approved these changes
Mar 3, 2023
AgentEnder
added a commit
to AgentEnder/nx
that referenced
this pull request
Mar 4, 2023
…llation (nrwl#15408)" This reverts commit e773bdb.
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There is no warnings or documentation to help guide users who have an outdated installation.
Expected Behavior
Starting with the next version, users who have it installed globally and the local copy of Nx is at least 1 major version higher will see warnings explaining that they have an outdated global install. Due to the nature of this change, users who currently have an outdated install will not see the warnings, but this at least helps future users or folks who upgrade it.
Additionally, there is a guide added to describe the upgrade process and be searchable. This guide is not currently linked anywhere from the sidebar, perhaps it should be on the more-concepts index though.
Related Issue(s)
Fixes #15112