Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(core): fix module federation config example #15349

Merged
merged 1 commit into from
Apr 6, 2023

Conversation

GraxMonzo
Copy link
Contributor

@GraxMonzo GraxMonzo commented Mar 1, 2023

fix: await without async callback fixed by: #15387
fix: withModuleFederation callback's second argument

@vercel
Copy link

vercel bot commented Mar 1, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 6, 2023 3:46pm

@GraxMonzo
Copy link
Contributor Author

Destructured argument context (ExecutorContext) from the callback does not match the parameter context (NxWebpackExecutionContext) of federatedModules:
image
Two ways of fixing this typo:
image
image

@GraxMonzo
Copy link
Contributor Author

Hello, I hope you're doing well. I wanted to thank you for your hard work on this project.
Just wanted to check in on my pull request. Is there anything else I can do to help it get merged?

@mandarini
Copy link
Member

Hi @GraxMonzo ! Sorry for taking so long here, thanks for your patience! :)

The main issue with your PR was that when you edit documentation (the .md files), then you have to run yarn documentation to generate our documentation files that are actually loaded in nx.dev. If you don't run this command, however, our pre-commit hook runs it for you, and blocks your commit if it ends up generating new files, and then asks you to add the newly generated files to your commit as well. Maybe you pushed your commit with --no-verify and skipped this hook, or maybe something else happened! Nothing to worry about though! To unblock you, I ran the command for you and added the generated file to your commit! Your PR should be getting merged soon! :) Thank you for contributing!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants