Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(nx-plugin): Add typescript to avoid peer dependency error on create-nx-plugin #15049

Closed
wants to merge 1 commit into from

Conversation

ahkhanjani
Copy link
Contributor

Current Behavior

Expected Behavior

Error stack:

.
└─┬ create-nx-plugin 15.7.1
  └─┬ @nrwl/devkit 15.7.1
    └─┬ @phenomnomnominal/tsquery 4.1.1
      └── ✕ missing peer typescript@"^3 || ^4"

Related Issue(s)

Fixes #

…te-nx-plugin

Error stack:

```
.
└─┬ create-nx-plugin 15.7.1
  └─┬ @nrwl/devkit 15.7.1
    └─┬ @phenomnomnominal/tsquery 4.1.1
      └── ✕ missing peer typescript@"^3 || ^4"
```
@vercel
Copy link

vercel bot commented Feb 16, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Feb 16, 2023 at 11:44AM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Feb 16, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 64564da. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@AgentEnder
Copy link
Member

create-nx-plugin shouldn't depend on devkit. We are fixing this. See: #15743

@AgentEnder AgentEnder closed this Mar 20, 2023
@ahkhanjani ahkhanjani deleted the patch-1 branch March 21, 2023 06:44
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants