fix(core): remove Windows cmd window popups

[Cammisuli]

Current Behavior

There are a few places where we launch subprocesses to deal with hashing. When this happened, we did not tell Windows to hide or detach the process. This then causes cmd windows to appear

Expected Behavior

No cmd windows should appear when running with the daemon or other nx commands

Related Issue(s)

Fixes #10822

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 13, 2023 at 11:35PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 71ff970. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=51cd35cb0437b6bcc5a00e83cd0fad3e66d9a309 --head=71ff970861fc02a15d6fc1ed0fc880bd09422b7e --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=51cd35cb0437b6bcc5a00e83cd0fad3e66d9a309 --head=71ff970861fc02a15d6fc1ed0fc880bd09422b7e --parallel=1
• nx affected --target=build --base=51cd35cb0437b6bcc5a00e83cd0fad3e66d9a309 --head=71ff970861fc02a15d6fc1ed0fc880bd09422b7e --parallel=3
• nx affected --target=lint --base=51cd35cb0437b6bcc5a00e83cd0fad3e66d9a309 --head=71ff970861fc02a15d6fc1ed0fc880bd09422b7e --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx-cloud record -- nx format:check --base=51cd35cb0437b6bcc5a00e83cd0fad3e66d9a309 --head=71ff970861fc02a15d6fc1ed0fc880bd09422b7e
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[FrozenPandaz]

So here's the rules?:

• execSync
  • needs windowsHide: true
• spawn
  • needs detached: true

[Cammisuli]

So here's the rules?:

* execSync
  
  * needs `windowsHide: true`

* spawn
  
  * needs `detached: true`

Yea, essentially. Basically if detached is there, use it with shell: false. Otherwise use windowsHide: true

[mayfieldiv]

@Cammisuli
After a fair bit of debugging why nx graph isn't resolving any explicit dependencies on my Windows machine, I've narrowed it down to the addition of detached: true in this MR, which is causing the stdout/stderr results from spawnProcess to always be empty (at least on my machine), so the git-hasher never returns any files. Removing detached: true seems to resolve the issue.

Please let me know if you'd like me to provide more info or if you're able to reproduce on your side.

[Cammisuli]

@mayfieldiv if you're having issues with the git hasher, try enabling the native hasher by setting $env:NX_NATIVE_HASHER='true' in your environment. In the next version of Nx (15.8.0) the native hasher will be on by default.

[mayfieldiv]

It looks like the native hasher doesn't return any files on Windows either in the latest master build. I think I have a fix for the relevant Rust code and will make a PR and tag you in it.

[thomas-ef]

Has this been released yet ?

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.