Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(node): Added E2E project generation option to NestJs app generator #14805

Merged
merged 1 commit into from
Mar 31, 2023

Conversation

FurlanLuka
Copy link
Contributor

Current Behavior

Since E2E project generation option has been added to Node app generator, NestJS app generator always generates E2E project

Expected Behavior

This PR adds a E2E test runner option to NestJS application generator schema, so you can choose not to have E2E tests with your NestJS project

Related Issue(s)

Implements #14572

@vercel
Copy link

vercel bot commented Feb 5, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Feb 5, 2023 at 11:48AM (UTC)

@FurlanLuka
Copy link
Contributor Author

Hello, can this be reviewed?

@AgentEnder AgentEnder requested review from ndcunningham and nartc March 1, 2023 00:25
@kdawgwilk
Copy link
Contributor

I think this is because the node-server generator always generates e2e project do we need to add an option to that generator first? And then have the nest generator pass the flag down?

@FurlanLuka
Copy link
Contributor Author

The option was already added to the node generator

@AgentEnder AgentEnder merged commit 3af649d into nrwl:master Mar 31, 2023
@AgentEnder AgentEnder mentioned this pull request Mar 31, 2023
4 tasks
@github-actions
Copy link

github-actions bot commented Apr 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants