Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(js): handle standalone projects for buildable js libraries #14615

Merged
merged 1 commit into from
Jan 25, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 25, 2023

Current Behavior

Expected Behavior

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 25, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 25, 2023 at 4:08PM (UTC)

@jaysoo jaysoo requested a review from nartc January 25, 2023 16:04
Copy link
Contributor

@nartc nartc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jaysoo jaysoo force-pushed the fix/buildable-standalone-js branch from 3619734 to 5308d83 Compare January 25, 2023 16:08
@jaysoo jaysoo enabled auto-merge (squash) January 25, 2023 16:10
@jaysoo jaysoo merged commit 4bbd60b into nrwl:master Jan 25, 2023
@jaysoo jaysoo deleted the fix/buildable-standalone-js branch January 25, 2023 16:33
FrozenPandaz pushed a commit that referenced this pull request Jan 27, 2023
@github-actions
Copy link

github-actions bot commented Mar 6, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants