cleanup(js): factor code-frames in nx

[vicb]

I recently sent a PR to display nicely formatted JSON errors (#14293) and then realize that there was something similar for JS in the js package - code-frames.

This PR factor the code-frames code in nx so that it is used in both cases (formatting JSON and JS errors).

This PR also clean up unused code in packages/js/src/utils/code-frames/identifiers.ts. It is very unlikely that someone else use the removed code. To make sure I run a query on github an the only usages were from inside nx.

The only difference between formatting a JS error vs a JSON error is that codeFrameColumns use to highlight the JS code passed to it. I have changed that so that the highlighted code is now passed in the options. That is used for JS but not for JSON - we don't highlight JSON code.

The colored test snapshots are not very readable but I made sure all of them are correct in bash:

$ echo  "InvalidCommentToken in JSON at 2:7
      ^[[0m ^[[90m 1 | ^[[39m{^[[0m
      ^[[0m^[[31m^[[1m>^[[22m^[[39m^[[90m 2 | ^[[39m      //\\"test\\": 123,^[[0m
      ^[[0m ^[[90m   | ^[[39m      ^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[31m^[[1m^^[[22m^[[39m^[[0m
      ^[[0m ^[[90m 3 | ^[[39m      \\"nested\\": {^[[0m
      ^[[0m ^[[90m 4 | ^[[39m          \\"test\\": 123^[[0m
      ^[[0m ^[[90m 5 | ^[[39m          /*^[[0m
      "
InvalidCommentToken in JSON at 2:7
        1 | {
      > 2 |       //\test\: 123,
          |       ^^^^^^^^^^^^^^
        3 |       \nested\: {
        4 |           \test\: 123
        5 |           /*     

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
nx-dev	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 3, 2023 at 5:17PM (UTC)

[nx-cloud]

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 228a8ab. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

---

✅ Successfully ran 8 targets

• nx run-many -t e2e-macos --parallel=1 --exclude=e2e-detox
• nx affected --target=e2e --base=b85f9de9e7e25c28ff15471fc9f08db852dd4144 --head=228a8ab20ee9951d9780111bb0e92fe18599997d --exclude=e2e-storybook,e2e-storybook-angular --parallel=1
• nx affected --target=test --base=b85f9de9e7e25c28ff15471fc9f08db852dd4144 --head=228a8ab20ee9951d9780111bb0e92fe18599997d --parallel=1
• nx affected --target=build --base=b85f9de9e7e25c28ff15471fc9f08db852dd4144 --head=228a8ab20ee9951d9780111bb0e92fe18599997d --parallel=3
• nx run-many -t root-lint check-imports check-commit check-lock-files depcheck --parallel=1 --no-dte
• nx affected --target=lint --base=b85f9de9e7e25c28ff15471fc9f08db852dd4144 --head=228a8ab20ee9951d9780111bb0e92fe18599997d --parallel=3
• nx-cloud record -- nx format:check --base=b85f9de9e7e25c28ff15471fc9f08db852dd4144 --head=228a8ab20ee9951d9780111bb0e92fe18599997d
• nx documentation --no-dte

---

Sent with 💌 from NxCloud.

[meeroslav]

Left one comment regarding the highlight function, but it's not a show stopper.

[jaysoo]

Are there any concerns for terminals that don't display colors? Maybe some CI systems?

For local development this makes sense, just want to check if we thought about fallbacks.

Thanks for the PR!

[vicb]

@meeroslav great suggestion. I'll update the PR soonish.

@jaysoo my understanding is that chalk handles that. Also this PR does not add colors but only re-use the existing JS error display for JSON.

Thanks to both of you for the feedback

[vicb]

I have rebased/updated the PR. Should be ready to go in if the CI is green.

[jaysoo]

Thanks. Let's merge it.

[vicb]

Thanks!

[github-actions]

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.