Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(angular): should find the tsconfig at root of project #14379 #14514

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 20, 2023

Current Behavior

We only set tsconfig.base.json as the tsconfig file to look for in the builder.

Expected Behavior

We only get the root tsconfig file to look for in the builder.

Related Issue(s)

Fixes #14379

@Coly010 Coly010 self-assigned this Jan 20, 2023
@vercel
Copy link

vercel bot commented Jan 20, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 20, 2023 at 1:40PM (UTC)

@Coly010 Coly010 requested a review from leosvelperez January 20, 2023 13:59
@Coly010 Coly010 merged commit ce04b80 into nrwl:master Jan 20, 2023
@Coly010 Coly010 deleted the angular/mf-helpers-tsconfig branch January 20, 2023 14:40
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nx creates tsconfig.json then looks for tsconfig.base.json for Angular project
2 participants