Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cleanup(angular): enable the ng-cli e2e test #14503

Merged

Conversation

leosvelperez
Copy link
Member

Enables back the previously disabled ng-cli.test.ts e2e tests. It's updated to use an executor from the Angular plugin and avoid the additional dependency on the Vite plugin.

@leosvelperez leosvelperez self-assigned this Jan 19, 2023
@vercel
Copy link

vercel bot commented Jan 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated
nx-dev ⬜️ Ignored (Inspect) Jan 19, 2023 at 5:51PM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 19, 2023

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 80a58cc. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch


✅ Successfully ran 1 target

Sent with 💌 from NxCloud.

@leosvelperez leosvelperez force-pushed the angular/enable-ng-cli-e2e-test branch from 5e2db45 to 80a58cc Compare January 19, 2023 17:51
@leosvelperez leosvelperez enabled auto-merge (squash) January 19, 2023 18:17
@leosvelperez leosvelperez merged commit 6c926d8 into nrwl:master Jan 19, 2023
@leosvelperez leosvelperez deleted the angular/enable-ng-cli-e2e-test branch January 20, 2023 09:22
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 9, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants