-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(react): add migration to install @nrwl/webpack if needed by Story… #14480
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
83 changes: 83 additions & 0 deletions
83
packages/storybook/src/migrations/update-15-5-3/ensure-webpack-package.spec.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,83 @@ | ||
| import { createTreeWithEmptyWorkspace } from '@nrwl/devkit/testing'; | ||
| import { | ||
| readJson, | ||
| writeJson, | ||
| addProjectConfiguration, | ||
| Tree, | ||
| } from '@nrwl/devkit'; | ||
| import update from './ensure-webpack-package'; | ||
|
|
||
| describe('ensure-webpack-package', () => { | ||
| let tree: Tree; | ||
|
|
||
| beforeEach(() => { | ||
| tree = createTreeWithEmptyWorkspace(); | ||
| writeJson(tree, 'package.json', { | ||
| dependencies: {}, | ||
| devDependencies: { | ||
| '@nrwl/react': '15.5.0', | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| it.each` | ||
| config | ||
| ${'main.ts'} | ||
| ${'main.js'} | ||
| `( | ||
| 'should install @nrwl/webpack if it is needed by React project', | ||
| async ({ config }) => { | ||
| addProjectConfiguration(tree, 'myapp', { | ||
| root: 'myapp', | ||
| }); | ||
| tree.write( | ||
| `myapp/.storybook/${config}`, | ||
| ` | ||
| module.exports = { | ||
| addons: ['@nrwl/react/plugins/storybook'] | ||
| }; | ||
| ` | ||
| ); | ||
|
|
||
| await update(tree); | ||
|
|
||
| const packageJson = readJson(tree, 'package.json'); | ||
| expect(packageJson.devDependencies).toEqual({ | ||
| '@nrwl/react': expect.any(String), | ||
| '@nrwl/webpack': expect.any(String), | ||
| }); | ||
| } | ||
| ); | ||
|
|
||
| it.each` | ||
| config | ||
| ${'main.ts'} | ||
| ${'main.js'} | ||
| ${null} | ||
| `( | ||
| 'should not install @nrwl/webpack if it is not needed by React project', | ||
| async ({ config }) => { | ||
| addProjectConfiguration(tree, 'myapp', { | ||
| root: 'myapp', | ||
| }); | ||
|
|
||
| if (config) { | ||
| tree.write( | ||
| `myapp/.storybook/${config}`, | ||
| ` | ||
| module.exports = { | ||
| addons: [] | ||
| }; | ||
| ` | ||
| ); | ||
| } | ||
|
|
||
| await update(tree); | ||
|
|
||
| const packageJson = readJson(tree, 'package.json'); | ||
| expect(packageJson.devDependencies).toEqual({ | ||
| '@nrwl/react': expect.any(String), | ||
| }); | ||
| } | ||
| ); | ||
| }); |
41 changes: 41 additions & 0 deletions
41
packages/storybook/src/migrations/update-15-5-3/ensure-webpack-package.ts
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,41 @@ | ||
| import { | ||
| addDependenciesToPackageJson, | ||
| getProjects, | ||
| joinPathFragments, | ||
| Tree, | ||
| } from '@nrwl/devkit'; | ||
| import { nxVersion } from '../../utils/versions'; | ||
|
|
||
| // Add @nrwl/webpack as needed. | ||
| // See: https://github.com/nrwl/nx/issues/14455 | ||
| export default async function update(tree: Tree) { | ||
| const projects = getProjects(tree); | ||
| const reactPlugin = '@nrwl/react/plugins/storybook'; | ||
| let shouldInstall = false; | ||
|
|
||
| for (const [, config] of projects) { | ||
| let sbConfigPath = joinPathFragments(config.root, '.storybook/main.ts'); | ||
|
|
||
| if (!tree.exists(sbConfigPath)) { | ||
| sbConfigPath = joinPathFragments(config.root, '.storybook/main.js'); | ||
| } | ||
|
|
||
| if (!tree.exists(sbConfigPath)) { | ||
| continue; | ||
| } | ||
|
|
||
| const sbConfig = tree.read(sbConfigPath, 'utf-8'); | ||
| if (sbConfig.includes(reactPlugin)) { | ||
| shouldInstall = true; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (shouldInstall) { | ||
| return addDependenciesToPackageJson( | ||
| tree, | ||
| {}, | ||
| { '@nrwl/webpack': nxVersion } | ||
| ); | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ideally, instead of
joinPathFragments(config.root, '.storybook/main.ts')it should look for the storybook target (by searching for the@nrwl/storybook:storybookexecutor) and get theconfigDir, but I guess it's overengineering in this case. So I think it looks good.