Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(webpack): fix optimization can't be turned off #14430

Closed
wants to merge 1 commit into from

Conversation

flippidippi
Copy link

Current Behavior

Currently optimization is always an object so minimization always happens

Expected Behavior

If optimization is set to false then it should not minimize

Related Issue(s)

Fixes #12782

@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 17, 2023 at 4:06PM (UTC)

@flippidippi
Copy link
Author

flippidippi commented Jan 17, 2023

implemented by @jaysoo in #14431

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@nrwl/webpack] Minification does not work correctly (with node target)
1 participant