Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vite): enable watch mode for preview #14412

Merged
merged 1 commit into from
Jan 18, 2023
Merged

Conversation

vicb
Copy link
Contributor

@vicb vicb commented Jan 17, 2023

Content of this PR:

  • Add a watch option for build,
  • Update the build executor to emit { success } at the end of a build,
  • Enable the watch mode by default for the preview executor,
  • Start the preview server after the first build success.

Fixes #14125 and tested locally.

/cc @mandarini

@vercel
Copy link

vercel bot commented Jan 17, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated
nx-dev ✅ Ready (Inspect) Visit Preview 💬 Add your feedback Jan 17, 2023 at 3:42AM (UTC)

@mandarini
Copy link
Member

Thanks for this @vicb !

@mandarini mandarini merged commit bd2b5ca into nrwl:master Jan 18, 2023
jaysoo pushed a commit to jaysoo/nx that referenced this pull request Jan 18, 2023
@vicb
Copy link
Contributor Author

vicb commented Jan 18, 2023

Thanks!

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for the preview mode of vite
2 participants