Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): fix imports in tmpl #14369

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Conversation

timfisher
Copy link
Contributor

Current Behavior

nx g @nrwl/react:host shell --remotes=shop,cart
nx g @nrwl/react:remote about --host=shell

Then run shell:build:production

The following error occurs:

NX Unexpected token ')'

const { withModuleFederation } = require('@nrwl/react/module-federation'));
^

SyntaxError: Unexpected token ')'

Expected Behavior

No error output/ compiles correctly.

Related Issue(s)

#14344

Fixes #

#14344

@vercel
Copy link

vercel bot commented Jan 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 14, 2023 at 6:30PM (UTC)

@timfisher timfisher force-pushed the fix/fix-imports-in-tmpl branch from 9aad88a to 7d5f7ad Compare January 14, 2023 18:29
@timfisher timfisher changed the title fix(webpack): fix imports in tmpl fix(react): fix imports in tmpl Jan 14, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants