Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(bundling): fix esbuild watch yields success=false when no error #14359

Merged
merged 1 commit into from
Jan 20, 2023

Conversation

taylorjames
Copy link
Contributor

Current Behavior

When using esbuild with watch=true, the onRebuild function returns success=false when there is no error.

Expected Behavior

When using esbuild with watch=true, the onRebuild function should return success=true when there is no error.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Jan 13, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 13, 2023 at 7:16PM (UTC)

@jaysoo jaysoo merged commit 2baa80d into nrwl:master Jan 20, 2023
FrozenPandaz pushed a commit that referenced this pull request Jan 20, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants