-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(testing): add lerna-smoke-tests #14347
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
☁️ Nx Cloud ReportCI is running/has finished running commands for commit 4ecf9f6. As they complete they will appear below. Click to see the status, the terminal output, and the build insights. 📂 See all runs for this branch ✅ Successfully ran 1 targetSent with 💌 from NxCloud. |
3952d8f
to
49bc60c
Compare
@@ -95,6 +95,9 @@ | |||
{ | |||
"env": "SELECTED_CLI" | |||
}, | |||
{ | |||
"env": "SELECTED_PM" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I discovered this was missing from the cache key when switching package managers locally to test this
You need to exclude lerna tests here:
|
Per slack discussion with Victor I refactored the CI config to use a dedicated |
(cherry picked from commit 965c638)
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Current Behavior
Nx devs are not prevented from making changes which break key assumptions in
lerna
, such as forlerna repair
orlerna run
.Expected Behavior
Lightweight lerna smoke tests catch any critical issues in CI and prevent them from being released