Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(angular): throw error when --standalone used for setup-mf w/ invalid Ng version #14270

Merged
merged 1 commit into from
Jan 11, 2023

Conversation

Coly010
Copy link
Contributor

@Coly010 Coly010 commented Jan 11, 2023

Current Behavior

We don't support --standalone for versions of angular < 14.1, but we do not error when generating

Expected Behavior

Error when generating to inform users that --standalone is not supported for their version

@Coly010 Coly010 requested a review from leosvelperez January 11, 2023 11:13
@Coly010 Coly010 self-assigned this Jan 11, 2023
@vercel
Copy link

vercel bot commented Jan 11, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Updated
nx-dev ⬜️ Ignored (Inspect) Jan 11, 2023 at 11:49AM (UTC)

Copy link
Member

@leosvelperez leosvelperez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Left a non-blocking suggestion.

packages/angular/src/generators/setup-mf/setup-mf.ts Outdated Show resolved Hide resolved
@Coly010 Coly010 force-pushed the angular/no-std-support-mf branch from ff5040b to 7fc2c12 Compare January 11, 2023 11:48
@Coly010 Coly010 enabled auto-merge (squash) January 11, 2023 12:02
@Coly010 Coly010 merged commit b0c6ca9 into nrwl:master Jan 11, 2023
@Coly010 Coly010 deleted the angular/no-std-support-mf branch January 11, 2023 12:26
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants