Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(nest): nx init nest #14254

Merged
merged 1 commit into from
Jan 13, 2023
Merged

feat(nest): nx init nest #14254

merged 1 commit into from
Jan 13, 2023

Conversation

nartc
Copy link
Contributor

@nartc nartc commented Jan 10, 2023 •
edited
Loading

Current Behavior

nx init does not recognize NestCLI application

Expected Behavior

nx init inside of a NestCLI application will turn that application into a Nx Standalone setup with @nrwl/nest

  • NestJS monorepo mode support is coming after this initial feature
  • --language=js support is coming after this initial feature

@vercel
Copy link

vercel bot commented Jan 10, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 13, 2023 at 6:10AM (UTC)

@nx-cloud
Copy link

nx-cloud bot commented Jan 10, 2023 •
edited
Loading

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 5d98804. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this branch

✅ Successfully ran 5 targets

Sent with 💌 from NxCloud.

@nartc nartc requested review from AgentEnder and jaysoo January 10, 2023 21:24
@nartc nartc marked this pull request as ready for review January 10, 2023 21:24
AgentEnder
AgentEnder requested changes Jan 10, 2023
View reviewed changes
packages/nx/src/command-line/init.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
packages/nx/src/nx-init/add-nx-to-nest.ts Outdated Show resolved Hide resolved
@nartc nartc requested a review from AgentEnder January 11, 2023 17:00
@nartc nartc merged commit 5faef5d into nrwl:master Jan 13, 2023
@github-actions github-actions bot mentioned this pull request Mar 4, 2023
Closed
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@AgentEnder AgentEnder AgentEnder approved these changes

@jaysoo jaysoo jaysoo approved these changes

Assignees

@nartc nartc

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@nartc @jaysoo @AgentEnder