Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(webpack): remove support for legacy browsers #14190

Merged
merged 1 commit into from
Jan 9, 2023

Conversation

jaysoo
Copy link
Member

@jaysoo jaysoo commented Jan 6, 2023

We haven't generated workspaces/apps with support for legacy browsers since Nx 12, yet we continue to add polyfills via polyfills.ts file. This adds additional 40-50 kB to the bundle for no reason due to polyfills. As well, we transform async/generator functions to use core-js and regenerator, which bloats the bundle.

Other frameworks such as Remix, Angular, Qwik don't support legacy browsers either.

Changes

  • Remove es2015Polyfills option and provide migration to remove it from existing apps
  • Remove logic to check if differential loading is required and always generate for modern browsers

@vercel
Copy link

vercel bot commented Jan 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Jan 6, 2023 at 8:00PM (UTC)

@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from a9977d8 to 64e321b Compare January 6, 2023 15:11
@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from 64e321b to 69ece71 Compare January 6, 2023 15:18
@jaysoo jaysoo changed the title feat(webpack): remove support for legacy browsers and the need for polyfills feat(webpack): remove support for legacy browsers Jan 6, 2023
@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from 69ece71 to 65419d3 Compare January 6, 2023 15:27
@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from 65419d3 to 273622a Compare January 6, 2023 16:13
@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from 273622a to 29e2fcc Compare January 6, 2023 17:56
@jaysoo jaysoo force-pushed the feat/remove-legacy-browser-support branch from 29e2fcc to a0b6fb0 Compare January 6, 2023 18:27
@jaysoo jaysoo marked this pull request as ready for review January 6, 2023 19:02
@jaysoo jaysoo requested review from mandarini and FrozenPandaz and removed request for mandarini January 6, 2023 19:02
@mandarini mandarini merged commit fcc02d1 into nrwl:master Jan 9, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 10, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
jaysoo added a commit to jaysoo/nx that referenced this pull request Jan 11, 2023
@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants