-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(webpack): remove support for legacy browsers #14190
Merged
mandarini
merged 1 commit into
nrwl:master
from
jaysoo:feat/remove-legacy-browser-support
Jan 9, 2023
Merged
feat(webpack): remove support for legacy browsers #14190
mandarini
merged 1 commit into
nrwl:master
from
jaysoo:feat/remove-legacy-browser-support
Jan 9, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 15:11
a9977d8
to
64e321b
Compare
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 15:18
64e321b
to
69ece71
Compare
jaysoo
changed the title
feat(webpack): remove support for legacy browsers and the need for polyfills
feat(webpack): remove support for legacy browsers
Jan 6, 2023
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 15:27
69ece71
to
65419d3
Compare
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 16:13
65419d3
to
273622a
Compare
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 17:56
273622a
to
29e2fcc
Compare
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 18:27
29e2fcc
to
a0b6fb0
Compare
jaysoo
requested review from
mandarini and
FrozenPandaz
and removed request for
mandarini
January 6, 2023 19:02
jaysoo
force-pushed
the
feat/remove-legacy-browser-support
branch
from
January 6, 2023 19:52
a0b6fb0
to
924aca3
Compare
mandarini
approved these changes
Jan 9, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 10, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
jaysoo
added a commit
to jaysoo/nx
that referenced
this pull request
Jan 11, 2023
mandarini
pushed a commit
that referenced
this pull request
Jan 11, 2023
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We haven't generated workspaces/apps with support for legacy browsers since Nx 12, yet we continue to add polyfills via polyfills.ts file. This adds additional 40-50 kB to the bundle for no reason due to polyfills. As well, we transform async/generator functions to use core-js and regenerator, which bloats the bundle.
Other frameworks such as Remix, Angular, Qwik don't support legacy browsers either.
Changes
es2015Polyfills
option and provide migration to remove it from existing apps