Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): fix dependent projects for watch #14170

Merged
merged 3 commits into from
Jan 11, 2023
Merged

fix(core): fix dependent projects for watch #14170

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
86283db
fix(core): fix dependent projects for watch
Cammisuli Jan 5, 2023
e32d25b
feat(core): optimize set
Cammisuli Jan 11, 2023
fdb7dba
feat(core): make sure watchedProjects is initialized with values
Cammisuli Jan 11, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/nx/src/daemon/server/file-watching/file-watcher-sockets.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@ export function notifyFileWatcherSockets(
const watchedProjects = [...config.watchProjects];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
const watchedProjects = [...config.watchProjects];
const watchedProjects = new Set()


if (config.includeDependentProjects) {
for (const project of watchedProjects) {
for (const project of config.watchProjects) {
watchedProjects.push(
...findAllProjectNodeDependencies(
project,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
for (const project of config.watchProjects) {
watchedProjects.push(
...findAllProjectNodeDependencies(
project,
for (const project of config.watchProjects) {
watchedProjects.add(project)
for (const dep of findAllProjectNodeDependencies(...)) {
watchedProjects.add(dep)
}
}

Expand Down