feat(misc): do not generate tsconfig.base.json for simple standalone … #13605
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
vsavkin
force-pushed
the
remove-tsconfig-base
branch
from
72417ef to
c3ffabe
Compare
vsavkin
force-pushed
the
remove-tsconfig-base
branch
from
c3ffabe to
2b7bf68
Compare
| for (let compilerOption of Object.keys(tsConfigBaseOptions)) { | ||
| baseCompilerOptions[compilerOption] = | ||
| tsconfig.compilerOptions[compilerOption]; | ||
| delete tsconfig.compilerOptions[compilerOption]; |
There was a problem hiding this comment.
You're going to end up with an empty compilerOptions? Why not just copy the whole object over and delete the original?
There was a problem hiding this comment.
Compiler options can change. People can add new options etc. Some compiler options are framework specific
| @@ -165,15 +155,6 @@ describe('app', () => { | |||
| const tsConfig = readJson(appTree, 'apps/my-app/tsconfig.json'); | |||
| expect(tsConfig.extends).toEqual('../../tsconfig.base.json'); | |||
| }); | |||
|
|
|||
| it('should extend from root tsconfig.json when no tsconfig.base.json', async () => { | |||
There was a problem hiding this comment.
Why was this removed?
There was a problem hiding this comment.
It no longer works like that. It will just extract tsconfig.base when ti is missing. So I updated one of the tests.
Bur for some reason we retest everything twice (with nested dirs and without), even though most of what we test has nothing to do with nested dirs.
vsavkin
force-pushed
the
remove-tsconfig-base
branch
from
2b7bf68 to
3c8bd6e
Compare
vsavkin
force-pushed
the
remove-tsconfig-base
branch
from
3c8bd6e to
038ee08
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
…repos
Current Behavior
Expected Behavior
Related Issue(s)
Fixes #