fix(schematics): only begin converting to workspace once files have been checked #136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vsavkin
reviewed
Dec 4, 2017
| }); | ||
|
|
||
| it('should error if no package.json is present', () => { | ||
| (expect as any).assertions(1); |
There was a problem hiding this comment.
can we use expect().toThrow instead of expect.assertions? similar to how we do it in ngrx.spec.ts?
There was a problem hiding this comment.
Thanks, updated!
JamesHenry
force-pushed
the
workspace-pre-checks
branch
from
1734685 to
7128075
Compare
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements my proposed solution from #134. I am obviously coming at this cold, so open to any and all feedback 😄
Updated to use
expect().toThrow()Closes #134