feat(storybook): generate config for vite #13381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
mandarini
force-pushed
the
feat/storybook-vite-gen
branch
from
13d615c to
13ab2ff
Compare
mandarini
force-pushed
the
feat/storybook-vite-gen
branch
from
13ab2ff to
b74bdd8
Compare
mandarini
force-pushed
the
feat/storybook-vite-gen
branch
from
19d3f31 to
9f7c5ec
Compare
mandarini
force-pushed
the
feat/storybook-vite-gen
branch
from
9f7c5ec to
7e5db9e
Compare
mandarini
force-pushed
the
feat/storybook-vite-gen
branch
from
7e5db9e to
fb577b0
Compare
jaysoo
reviewed
Nov 25, 2022
| @@ -105,6 +105,20 @@ describe('@nrwl/storybook:configuration for workspaces with Root project', () => | |||
| expect(tree.exists('.storybook/main.ts')).toBeTruthy(); | |||
| expect(tree.exists('.storybook/tsconfig.json')).toBeTruthy(); | |||
| expect(tree.exists('.storybook/preview.ts')).toBeTruthy(); | |||
|
|
|||
| expect(tree.read('.storybook/main.ts', 'utf-8')).toMatchSnapshot(); | |||
There was a problem hiding this comment.
Since we're checking snapshots, the previous existence assertions aren't needed.
|
LGTM, just added a comment about test assertions. We can clean that up later too. |
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Generate Storybook configuration using Vite.