fix(core): disallow edges to the root project #13359
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
There are some config files in the root of the workspace such as
/.storybook/main.js
which are imported from configs within libraries within the workspace (libs/ui/.storybook/main.js
) which will cause an edge. Many times, this will create a circular dependency because the root app will depend on that same lib.Expected Behavior
Though it is within the root app's directory,
.storybook/main.js
isn't really part of the app that lives at the root. If it were to be moved into its own directory,.storybook/main.js
would not be moved with it. This change ignores these edges until we have a better way of indicating that.storybook/main.js
is not part of the root app.Related Issue(s)
Fixes #