Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(core): disallow edges to the root project #13359

Merged
merged 1 commit into from
Nov 23, 2022

Conversation

FrozenPandaz
Copy link
Collaborator

Current Behavior

There are some config files in the root of the workspace such as /.storybook/main.js which are imported from configs within libraries within the workspace (libs/ui/.storybook/main.js) which will cause an edge. Many times, this will create a circular dependency because the root app will depend on that same lib.

Expected Behavior

Though it is within the root app's directory, .storybook/main.js isn't really part of the app that lives at the root. If it were to be moved into its own directory, .storybook/main.js would not be moved with it. This change ignores these edges until we have a better way of indicating that .storybook/main.js is not part of the root app.

Related Issue(s)

Fixes #

@vercel
Copy link

vercel bot commented Nov 23, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
nx-dev ✅ Ready (Inspect) Visit Preview Nov 23, 2022 at 4:29PM (UTC)

@github-actions
Copy link

This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant