feat(testing): support root project generation for jest #13353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
barbados-clemens
force-pushed
the
feat/nested-projects-jest
branch
2 times, most recently
from
367f2de to
4c95853
Compare
barbados-clemens
added
the
scope: testing tools
barbados-clemens
force-pushed
the
feat/nested-projects-jest
branch
from
4c95853 to
1cd5c8a
Compare
meeroslav
force-pushed
the
feat/nested-projects-jest
branch
from
1cd5c8a to
0b45d7c
Compare
meeroslav
reviewed
Nov 24, 2022
meeroslav
reviewed
Nov 24, 2022
meeroslav
reviewed
Nov 24, 2022
meeroslav
reviewed
Nov 24, 2022
meeroslav
reviewed
Nov 24, 2022
meeroslav
reviewed
Nov 24, 2022
packages/jest/src/generators/jest-project/lib/update-jestconfig.ts
Outdated
Show resolved
Hide resolved
FrozenPandaz
requested changes
Nov 28, 2022
barbados-clemens
force-pushed
the
feat/nested-projects-jest
branch
from
996b8fd to
476b31a
Compare
barbados-clemens
force-pushed
the
feat/nested-projects-jest
branch
from
476b31a to
bdef478
Compare
barbados-clemens
force-pushed
the
feat/nested-projects-jest
branch
from
bdef478 to
8ae62cf
Compare
| @@ -27,7 +27,8 @@ export function createFiles(tree: Tree, options: JestProjectSchema) { | |||
| ...options, | |||
| transformer, | |||
| js: !!options.js, | |||
| projectRoot: projectConfig.root, | |||
| rootProject: options.rootProject, | |||
| projectRoot: options.rootProject ? options.project : projectConfig.root, | |||
There was a problem hiding this comment.
How come this changed?
| updateFile, | ||
| expectJestTestsToPass, | ||
| cleanupProject, | ||
| readFile, | ||
| checkFilesExist, |
FrozenPandaz
approved these changes
Nov 29, 2022
|
This pull request has already been merged/closed. If you experience issues related to these changes, please open a new issue referencing this pull request. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Behavior
@nrwl/jest does not work with experimental root projects
Expected Behavior
Enable jest to run in the experimental single root project setup and update configurations to support multi project jest projects when adding new projects with nx
Related Issue(s)
TODO
getJestProjects()is used